Skip to content

fix: skip CSS fragment identifiers in module warnings#14079

Merged
nachocodoner merged 3 commits intometeor:release-3.4.1from
sanki92:fix/css-fragment-identifier-warning
Mar 24, 2026
Merged

fix: skip CSS fragment identifiers in module warnings#14079
nachocodoner merged 3 commits intometeor:release-3.4.1from
sanki92:fix/css-fragment-identifier-warning

Conversation

@sanki92
Copy link
Copy Markdown
Contributor

@sanki92 sanki92 commented Jan 12, 2026

Fix CSS Fragment Identifier False Warnings

Problem

When using CSS libraries like Leaflet, users see spurious "Unable to resolve module" warnings:

Unable to resolve some modules:
  "#default#VML" in /packages/...leaflet.css (web.browser)

This occurs with CSS containing fragment identifiers in url() values, particularly IE-specific behaviors like behavior: url(#default#VML);

Root Cause

  • Meteor's import scanner treats CSS fragment identifiers (starting with #) as module imports
  • Fragment identifiers are valid CSS but never represent JavaScript modules

Solution

Added check in PackageSourceBatch._warnAboutMissingModules() to skip IDs starting with #.

Changes Made

  • Added early return for identifiers starting with #
  • No impact on actual module resolution, only suppresses false warnings

Fixes #14037

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 12, 2026

Deploy Preview for v3-meteor-api-docs ready!

Name Link
🔨 Latest commit 8b6d83c
🔍 Latest deploy log https://app.netlify.com/projects/v3-meteor-api-docs/deploys/698ca6e52dc2ad00085a0d5a
😎 Deploy Preview https://deploy-preview-14079.docs-online.meteor.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 12, 2026

Deploy Preview for v3-migration-docs canceled.

Name Link
🔨 Latest commit cbec66d
🔍 Latest deploy log https://app.netlify.com/projects/v3-migration-docs/deploys/6965366c595cb700082dc291

@nachocodoner nachocodoner changed the base branch from devel to release-3.4 January 13, 2026 11:04
@nachocodoner nachocodoner changed the base branch from release-3.4 to release-3.4.1 January 13, 2026 11:04
@nachocodoner nachocodoner added this to the Release 3.4.1 milestone Jan 13, 2026
@nachocodoner nachocodoner self-requested a review January 13, 2026 11:05
@nachocodoner
Copy link
Copy Markdown
Member

nachocodoner commented Jan 13, 2026

I will check this fix with the reproduction soon. For the moment we'll plan to add this change with 3.4.1 as this doesn't seem to have a functional impact.

Thank you for providing this fix!

Copy link
Copy Markdown
Member

@nachocodoner nachocodoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes it apparently. Tested locally. Merging.

image

@nachocodoner nachocodoner merged commit 60cdbb6 into meteor:release-3.4.1 Mar 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.4-beta/rc-1] Unable to resolve module "#default#VML"

2 participants