Integrate lai:collection-extensions into core#13830
Integrate lai:collection-extensions into core#13830nachocodoner merged 25 commits intometeor:release-3.4from
Conversation
✅ Deploy Preview for v3-migration-docs canceled.
|
✅ Deploy Preview for v3-meteor-api-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I think it's ready for a review now @radekmie @fredmaiaarantes @nachocodoner |
|
Overall, the PR looks good, with detailed tests and documentation included. As for including it in Core, the feature is clear, low maintenance, and important for consistent Collection expansion in community packages and app code. I’ll ask the team for their feedback. |
e60bab9 to
8cee778
Compare
…teor into mongo/collection-extensions
radekmie
left a comment
There was a problem hiding this comment.
The only thing I'm missing is the type definitions.
|
The typescript dude emerges once again. I'll have a look and let you know. |
|
Please include this in 3.3.1 if possible. @nachocodoner |
|
I'll let @radekmie give his review, but on my end, it looks good. I think this pr has the same reasoning to go in 3.4 as this one from Storytelller: #13848 (comment) The TL;DR; is we would like to make 3.4 a big one with more highlights. 3.3.1 is a patch just to solve the latent issues we currently have in 3.3 |
|
Thank you Gabriel for your prompt reply and review. That's definitely understandable but I was keen on getting an RC out so I can starting testing. |
radekmie
left a comment
There was a problem hiding this comment.
If everyone else is fine with this PR, please don't block it because of me!
|
Are the failing test a result of my changes or something off with the CI? @italojs @nachocodoner EDIT: ping? |
|
We'll merge this PR as part of Meteor 3.4 contribution phase, so that we can have time to test Rspack bundler in isolation. I have set the milestone for it. |
nachocodoner
left a comment
There was a problem hiding this comment.
This PR is ready! Lets merge it for a Meteor 3.4 beta 😄
Great work @harryadel 🚀
|
|
Meteor offers no built-in way to extend the
Mongo.Collectionobject and this leads to cascading problem in many community packages which try to monkey-patch their way into the core, so hopefully by adding this to the core it opens up the door to better architect community packages.