Conversation
|
If we are going to merge this as one PR, then 2.6 release is a good candidate and we need to do it soon so that all changes follow from that otherwise we will spiral into endless merge resolutions. |
|
@StorytellerCZ like I said, I'm down to solve any comments you guys have but meteor/blaze#359 needs to be merged to fix the tests. |
|
Hi @harryadel, the tests are not passing, and also you are changing multiple packages. I know the change is the same, but multiple PRs are necessary to get good coverage in the reviews. As our Contribution guidelines say:
You can keep a single branch for your work, but please open different PRs for each package, ok? |
|
@filipenevola
|
|
We have to wait for the release of 2.6 to retest things as it's failing because of the unavailability of the blaze packages. buf: '=> Running Meteor from a checkout -- overrides project version (Meteor 1.10.1)\n' +
'=> Errors while initializing project:\n' +
'\n' +
'While selecting package versions:\n' +
'error: No version of blaze-html-templates satisfies all constraints: @1.0.4, @=2.0.0\n' +
'Constraints on package "blaze-html-templates":\n' +
'* blaze-html-templates@1.0.4 <- top level\n' +
'* blaze-html-templates@=2.0.0 <- top level\n' +
'\n',
fullBuffer: '=> Running Meteor from a checkout -- overrides project version (Meteor 1.10.1)\n' +
'=> Errors while initializing project:\n' +
'\n' +
'While selecting package versions:\n' +
'error: No version of blaze-html-templates satisfies all constraints: @1.0.4, @=2.0.0\n' +
'Constraints on package "blaze-html-templates":\n' +
'* blaze-html-templates@1.0.4 <- top level\n' +
'* blaze-html-templates@=2.0.0 <- top level\n' +
'\n', |
|
Hi, have already considered updating this package |
|
@diavrank that is not a core package, so it is out of scope here. You should contact the package maintainers for that. |
|
@StorytellerCZ the thing here is that it is a unmaintained package but it is still used by many developers. Can we have a compat package for that? |
Hey, @diavrank could you make this request an issue? so that we can discuss it and be trackable :) |
ce32c4f to
5695939
Compare
I tried to apply what we learned in meteor/blaze#331
Relevant issues: meteor/meteor-feature-requests#48
#1009 (comment)