Merge pull request #13850 from meteor/italo/npm-mongo-legacy

nachocodoner · web-flow · commit 8d9bc7dc7a37 · 2025-07-21T14:06:30.000+02:00
Handling MongoCompatibilityError when connect into mongodb driver 6.x
diff --git a/packages/mongo/tests/mongo_livedata_tests.js b/packages/mongo/tests/mongo_livedata_tests.js
@@ -4298,9 +4298,10 @@ Tinytest.addAsync(
     await Collection.updateAsync({ _id: 'a' }, { $set: { num: 1 } });
     await Collection.updateAsync({ _id: 'b' }, { $set: { num: 2 } });
 
+    if(Meteor.isClient) Meteor._sleepForMs(100); // wait for async operations to complete 
     items = await Collection.find().fetchAsync();
     itemIds = items.map(_item => _item.num);
-
+    
     test.equal(itemIds, [1, 2]);
 
     await Collection.removeAsync({ _id: 'a' });
diff --git a/packages/npm-mongo/wrapper.js b/packages/npm-mongo/wrapper.js
@@ -1,6 +1,37 @@
-const useLegacyMongo = !!Package['npm-mongo-legacy'];
+const { MongoClient, MongoCompatibilityError } = Npm.require('mongodb');
 
+function connect(client) {
+  return client.connect()
+    .catch(error => {
+      if (error.cause instanceof MongoCompatibilityError && error.message.includes('maximum wire version')) {
+      console.warn(`[DEPRECATION] Legacy MongoDB version detected, using mongo-legacy package: ${error.message}
+        Warning: MongoDB versions <= 3.6 are deprecated. Some Meteor features may not work properly with this version.
+        It is recommended to use MongoDB >= 4.`);
+      if (!Package['npm-mongo-legacy']) {
+        throw new Error('Please, install npm-mongo-legacy package to use this version of MongoDB running "meteor add npm-mongo-legacy", then move the listed package inside .meteor/packages to the top.');
+      }
+      return false
+    } else {
+      throw new Error(`Failed to initialize Meteor's npm-mongo package: ${error}`);
+    }
+  })
+}
+
+if (process.env.MONGO_URL && (/^mongodb(\+srv)?:\/\//.test(process.env.MONGO_URL))) {
+  try {
+    connect(new MongoClient(process.env.MONGO_URL)).then(client => {
+      if (client) client.close();
+    });
+  } catch (e) {
+    console.warn('Invalid MongoDB connection string in MONGO_URL:', process.env.MONGO_URL);
+  }
+}
+
+const useLegacyMongo = !!Package['npm-mongo-legacy']
 const oldNoDeprecationValue = process.noDeprecation;
+
+useLegacyMongo && console.log('WARN: npm-mongo-legacy package detected, using package for mongo <= 3.6');
+
 try {
   // Silence deprecation warnings introduced in a patch update to mongodb:
   // https://github.com/meteor/meteor/pull/9942#discussion_r218564879
@@ -14,4 +45,4 @@ try {
 
 NpmModuleMongodbVersion = useLegacyMongo
   ? Package['npm-mongo-legacy'].NpmModuleMongodbVersion
-  : Npm.require('mongodb/package.json').version;
+  : Npm.require('mongodb/package.json').version;
diff --git a/packages/tinytest/tinytest.js b/packages/tinytest/tinytest.js
@@ -74,7 +74,7 @@ export class TestCaseResults {
         var frame = stack[i];
         // Heuristic: use the OUTERMOST line which is in a :tests.js
         // file (this is less likely to be a test helper function).
-        const fileName = frame.getFileName();
+        const fileName = frame?.getFileName ? frame.getFileName() : null;
         if (fileName && fileName.match(/:tests\.js/)) {
           doc.filename = fileName;
           doc.line = frame.getLineNumber();
diff --git a/tools/project-context.js b/tools/project-context.js
@@ -1217,7 +1217,16 @@ Object.assign(exports.ProjectConstraintsFile.prototype, {
           constraint: constraintToAdd,
           trailingSpaceAndComment: ''
         };
-        self._constraintLines.push(lineRecord);
+        if (constraintToAdd.package === 'npm-mongo-legacy') {
+          const mongoIdx = self._constraintLines.findIndex(lr => lr.constraint && lr.constraint.package === 'mongo');
+          if (mongoIdx > -1) {
+            self._constraintLines.splice(mongoIdx, 0, lineRecord);
+          } else {
+            self._constraintLines.push(lineRecord);
+          }
+        } else {
+          self._constraintLines.push(lineRecord);
+        }
         self._constraintMap[constraintToAdd.package] = lineRecord;
         self._modified = true;
         return;
