Skip to content

Remove upper bounds on versions of cereal and crypto-api#14

Closed
larskuhtz wants to merge 1 commit intometeficha:masterfrom
alephcloud:master
Closed

Remove upper bounds on versions of cereal and crypto-api#14
larskuhtz wants to merge 1 commit intometeficha:masterfrom
alephcloud:master

Conversation

@larskuhtz
Copy link
Copy Markdown

@larskuhtz larskuhtz commented Jan 6, 2014

The upper bounds for cereal and crypto-api do exclude the most recent versions of these packages. After removing the bounds the package still builds and works for me. I haven't done any specific tests. I guess that serialization with the new version of cereal is backward compatible but I haven't checked.

@cosmo0920 cosmo0920 mentioned this pull request Jan 7, 2014
Merged
@kazu-yamamoto
Copy link
Copy Markdown

kazu-yamamoto commented Jan 8, 2014

I also wish that a new version including this patch will be released soon.

@vincenthz
Copy link
Copy Markdown

vincenthz commented Jan 8, 2014

Just got bitten by this too, @meteficha please remove the upper bounds.

@pbrisbin pbrisbin mentioned this pull request Jan 10, 2014
Merged
@AaronFriel
Copy link
Copy Markdown

AaronFriel commented Jan 12, 2014

Seconded. Please increase upper bounds to allow anything up to the next major version, at least. i.e.: 1.0 for 0.x dependencies.

@pbrisbin pbrisbin mentioned this pull request Jan 15, 2014
Closed
@meteficha
Copy link
Copy Markdown
Owner

meteficha commented Feb 18, 2014

Hey, guys! Sorry I've been MIA for a few months. It seems to me that @snoyberg fixed the current problems by just bumping the version constraints, so does anybody still has any problems with skein-1.0.8.1?

In general, I don't like removing upper bounds, especially for crypto-api which has seen quite a few breaking changes without ever reaching 1.0. Usually I'm responsive enough to bump the constraints before creating too much hassles, but I've clearly failed this time. Still, I'm not sure if dropping the upper bounds is the best course of action.

If anybody has any comments to share about this, I'm all ears. And again, sorry for not taking care of skein.

@meteficha
Copy link
Copy Markdown
Owner

meteficha commented Apr 3, 2014

Well, closing this issue then. :)

@meteficha meteficha closed this Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@larskuhtz @kazu-yamamoto @vincenthz @AaronFriel @meteficha