Support Build Tools#9
Merged
dra27 merged 2 commits intometastack:masterfrom Sep 3, 2021
diskuv:feature-msbuild
Merged
Conversation
Contributor
Author
|
@dra27 Not urgent; just name-dropping since you had mentioned this repo last week, so this and #8 were opened. FYI: I won't be able to use |
Contributor
|
Thanks for these! |
Contributor
|
I just cut a release with your two fixes (and another more minor one I discovered working on OCaml Labs' docker images). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
vswhere.exe. This PR adds-products *to the vswhere command line options.So
& "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -allwhich is the existing code does not detect Build Tools installations.While
& "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -all -products *does detect Build Tools installations.(Can split PR if needed)