Simplify the search of the Microsoft Linker#14
Merged
dra27 merged 1 commit intometastack:masterfrom Nov 21, 2023
Merged
Conversation
dra27
reviewed
Nov 17, 2023
Contributor
dra27
left a comment
There was a problem hiding this comment.
This is so much better than my original, thank you! A few tiny nits and we do need to worry about escaping still in the final output (I double-checked that my favourite C:\Devel\This 'evil' bindir added to PATH still works!), but otherwise the logic behind this is much, much nicer and not calling out to anything other than command is excellent.
Promote the path of the MSVC cl compiler, to avoid launching all the `link` commands in $PATH Use only bash builtins, to speed up the search further Co-authored-by: David Allsopp <david.allsopp@metastack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the path of the MSVC cl compiler, to avoid launching all the
linkcommands in$PATHUse only bash builtins, to speed up the search further