This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Allow lower loglevel for logfiles (fixes #57)#338
Merged
Conversation
f098429 to
9478226
Compare
metachris
commented
Oct 19, 2020
| logger.addHandler(rotating_filehandler) | ||
| # If wanting to use a lower loglevel for the file handler, we need to reconfigure the logger level | ||
| # (note: this won't change the StreamHandler loglevel) | ||
| if loglevel and loglevel < logger.level: |
Owner
Author
There was a problem hiding this comment.
This is the relevant code change for logfile(...).
af92765 to
755e887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #57
Previously using a lower loglevel for a file logger than for the stream logger was not possible. This PR fixes it by adjusting the logger level if needed.