add padden_tokens so max_token_count is not exceeded#789
add padden_tokens so max_token_count is not exceeded#789nikvaessen wants to merge 9 commits intometa-pytorch:mainfrom
padden_tokens so max_token_count is not exceeded#789Conversation
|
Hi @nikvaessen! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I'm unsure what the best name for the proposed argument is. |
ejguan
left a comment
There was a problem hiding this comment.
Overall good. A few more comments below. Thank you
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Fixes #788
Changes
include_paddingargument toMaxTokenBucketizer