Closed
Conversation
VirrageS
reviewed
Jul 21, 2022
NivekT
approved these changes
Jul 21, 2022
Contributor
NivekT
left a comment
There was a problem hiding this comment.
Thanks for the fixes! Mostly SGTM! The main question I have is whether we want users to have aistore == 1.0.2 or aistore >= 1.0.2 and keeping that consistent throughout out messages to users.
Contributor
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Signed-off-by: Abhishek Gaikwad <gaikwadabhishek1997@gmail.com>
Contributor
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aisio.py changes to reflect the new aistore package (recent restructuring of APIs)
Changes
Signed-off-by: Abhishek Gaikwad gaikwadabhishek1997@gmail.com