Fix max_concurrent instance check and error message#1420
Merged
andrewkho merged 2 commits intometa-pytorch:mainfrom Jan 28, 2025
Merged
Fix max_concurrent instance check and error message#1420andrewkho merged 2 commits intometa-pytorch:mainfrom
andrewkho merged 2 commits intometa-pytorch:mainfrom
Conversation
divyanshk
approved these changes
Jan 9, 2025
Contributor
divyanshk
left a comment
There was a problem hiding this comment.
Thanks for fixing this, looks good to me!
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1420
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5804e04 with merge base e25df94 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
Is there anything needed from my side here? Seems like these are failing for an unrelated reason? |
Contributor
|
These test failures look like they're pre-existing and unrelated, thanks for the PR |
Contributor
|
Rebasing and re-starting CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read through our contribution guide prior to
creating your pull request.
functionality and testing.
Changes
isinstancecheck and modified the error message accordingly.