remove unused _pin_memory property in PinMemory class #1413
Merged
andrewkho merged 1 commit intometa-pytorch:mainfrom Dec 30, 2024
FightingZhen:main
Merged
remove unused _pin_memory property in PinMemory class #1413andrewkho merged 1 commit intometa-pytorch:mainfrom FightingZhen:main
andrewkho merged 1 commit intometa-pytorch:mainfrom
FightingZhen:main
Conversation
Contributor
|
Thanks @FightingZhen for the PR! Can you elaborate more on your use-case for this? |
Contributor
|
I assume it's to get parity with this: https://github.com/pytorch/pytorch/blob/main/torch/utils/data/_utils/pin_memory.py#L31 . side note @divyanshk we need to do a sync for stateful_dataloader, updating our tests and code to match pytorch core's dataloader v1 |
Contributor
|
@FightingZhen any ideas on how to test this? Looks like this PR in pytorch/pytorch landed without tests: pytorch/pytorch@3460b2b |
andrewkho
reviewed
Dec 27, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1413
Note: Links to docs will display an error until the docs builds have been completed. ❌ 26 New FailuresAs of commit f94164b with merge base 62092dd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Starting an internal CI run to run GPU tests |
Contributor
|
Wonder if there was a change to CI runners that broke determinism, the broken tests seem to be related to controlled randomness. Either way, I ran the tests after deleting and everything seems to pass so we should be good |
Contributor
Author
|
@andrewkho The CI looks finished, I'm not sure whether the above failed jobs is related with my modification or not, can this PR be merged? :) |
Contributor
|
@FightingZhen yup please go ahead and merge, thank you for your contribution! |
Contributor
Author
|
@divyanshk can you help me merge this pr? thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read through our contribution guide prior to
creating your pull request.
functionality and testing.
Fixes #{issue number}
Changes