Skip to content

Prevent in_memory_cache from yielding from source_dp when it's fully cached#1160

Closed
hirayaku wants to merge 1 commit intometa-pytorch:mainfrom
hirayaku:inmem-cache-fix
Closed

Prevent in_memory_cache from yielding from source_dp when it's fully cached#1160
hirayaku wants to merge 1 commit intometa-pytorch:mainfrom
hirayaku:inmem-cache-fix

Conversation

@hirayaku
Copy link
Contributor

Fixes #1159.

@facebook-github-bot
Copy link
Contributor

Hi @hirayaku!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2023
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@ejguan
Copy link
Contributor

ejguan commented May 15, 2023

@hirayaku Sorry that I need you to sign the CLA to merge this PR. THanks

@hirayaku
Copy link
Contributor Author

Hi, CLA is already signed and the status is updated. Thank you.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan merged this pull request in ba31745.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InMemoryCache dp will yield from source dp once even when data is fully cached

4 participants