Accept frozenset and Mapping in type stubs#119
Merged
messense merged 1 commit intomessense:mainfrom Mar 25, 2026
Merged
Conversation
messense
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyO3 has supported extracting
HashSetfrom bothsetandfrozensetsince0.22, but the type stubs only declared
Set[str]for set parameters andDictfor mapping parameters. This meant type checkers like pyright would reject
perfectly valid calls like
nh3.clean(html, tags=frozenset({"b"})).I switched the parameter types to
AbstractSetandMapping— this correctlyreflects what PyO3 accepts at runtime. Constants like
ALLOWED_TAGSstay typedas
Set[str]since they are concrete sets returned by ammonia.Also added a couple of tests to verify frozenset works at runtime.
Closes #29