Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accessor
getMF1Functions()is replaced with a staticMF1Functions, which contains an expanded set of MF1 compatibility functions; most of these wrap default or draft MF2 spec functions.A validator
mf1Validate()is provided. This is not run duringmf1ToMessage(), though, as the functions now validate their options at runtime (this provides for better fallback).MF1 syntax support is extended, so datetime & number skeletons + number patterns are now supported. As the MF2 option bags do not provide all of the same features, a best effort is made to match the input. The number format
scale/ddddtoken is specifically supported, however, as it's often required for percentage formatting.