DOC: add docs on using the build-dir config setting#616
Merged
rgommers merged 1 commit intomesonbuild:mainfrom May 16, 2024
Merged
DOC: add docs on using the build-dir config setting#616rgommers merged 1 commit intomesonbuild:mainfrom
build-dir config setting#616rgommers merged 1 commit intomesonbuild:mainfrom
Conversation
Contributor
Author
|
Addressed all comments, I think this is ready now. |
Contributor
Author
|
Cirrus is not happy. Can be ignored for this PR, since its docs-only. |
Member
|
@rgommers I find fixing prose via GitHub reviews not very efficient. I edited your text to make it flow better and pushed it to your branch. No conceptual changes intended. Please have a look. |
Closes mesonbuildgh-540 Also touches on mesonbuildgh-246, which is a common enough hiccup that it's useful to explicitly show dealing with `meson-log.txt` in CI.
Contributor
|
We could change the other places that have a pip version to use |
Contributor
Author
Agreed. |
Contributor
Author
|
The rephrasings LGTM - time to get this in. Thanks @dnicolodi and @henryiii |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-540
Also touches on gh-246, which is a common enough hiccup that it's useful to explicitly show dealing with
meson-log.txtin CI.