Skip to content

Update key generation#277

Merged
Hunter275 merged 21 commits into
meshtastic:pkifrom
KomelT:feature/security-tab
Sep 8, 2024
Merged

Update key generation#277
Hunter275 merged 21 commits into
meshtastic:pkifrom
KomelT:feature/security-tab

Conversation

@KomelT

@KomelT KomelT commented Aug 23, 2024

Copy link
Copy Markdown
Member

@Hunter275

Hunter275 commented Aug 24, 2024

Copy link
Copy Markdown
Member

@KomelT

We shouldn't need to generate the Admin Key, it will be the key of another device.

We should also add a confirmation dialog for generating a new Private Key.

I will add these to #272

@KomelT

KomelT commented Aug 24, 2024

Copy link
Copy Markdown
Member Author

@Hunter275 yes you are right, I miss-read the comment. Thanks.

Comment thread src/core/utils/x25519.ts Outdated
@KomelT KomelT force-pushed the feature/security-tab branch from ed0a34b to 4bde402 Compare August 29, 2024 21:19
@jp-bennett

jp-bennett commented Sep 2, 2024

Copy link
Copy Markdown

Key generation seems to be working as expected now. There are a couple little issues I've seen. First, having legacy admin enabled actually disables the private key field, where it should be disabling the admin key. (Though technically both can be turned on if somebody really wanted to).

Next, I don't understand the submit button, as none of the other fields have this. It does seem to be required to get settings to stick, to hit submit first, then the save icon.

And finally, if a user pasts a private key in to the field, this should blank out the public key, so the firmware will regenerate the appropriate key. Nevermind, the web app correctly regenerates the public key, and I didn't notice. 0=)

@Hunter275 Hunter275 added feature request New feature or request major change This is a major change parity Feature is in other app (iOS, Android, etc) labels Sep 5, 2024
Comment thread src/components/PageComponents/Config/Security.tsx Outdated
@Hunter275 Hunter275 requested a review from thebentern September 8, 2024 00:37
@Hunter275 Hunter275 merged commit 2e12b27 into meshtastic:pki Sep 8, 2024
@KomelT KomelT deleted the feature/security-tab branch September 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request major change This is a major change parity Feature is in other app (iOS, Android, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants