Skip to content

PSK Generator#266

Merged
Hunter275 merged 11 commits into
meshtastic:masterfrom
Hunter275:issue-261-password-generator
Aug 15, 2024
Merged

PSK Generator#266
Hunter275 merged 11 commits into
meshtastic:masterfrom
Hunter275:issue-261-password-generator

Conversation

@Hunter275

@Hunter275 Hunter275 commented Jul 28, 2024

Copy link
Copy Markdown
Member

Added a password generator to match iOS ability.

TODO:
Button changes input value ✅
PSK length dropdown changes password generation ✅
PSK key generation ✅
PSK loading from device ✅
PSK saving to device ✅
PSK length validation ✅

@Hunter275

Copy link
Copy Markdown
Member Author

To generate a password on iOS:

https://github.com/meshtastic/Meshtastic-Apple/blob/07c1018b538ea3bedd72ed243d9041d723650cb4/Meshtastic/Views/Settings/Channels.swift#L17

We use SecRandomCopyBytes() (https://developer.apple.com/documentation/security/1399291-secrandomcopybytes) to create a random input and then we encode it using base64EncodedString()

@Hunter275 Hunter275 changed the title added password generator PSK Generator Jul 28, 2024
@Hunter275 Hunter275 linked an issue Jul 28, 2024 that may be closed by this pull request
@Hunter275 Hunter275 added feature request New feature or request help wanted Extra attention is needed minor change This is a minor change parity Feature is in other app (iOS, Android, etc) major change This is a major change and removed minor change This is a minor change labels Jul 29, 2024
@Hunter275 Hunter275 mentioned this pull request Aug 8, 2024
@Hunter275 Hunter275 marked this pull request as ready for review August 10, 2024 23:54
@Hunter275 Hunter275 requested a review from thebentern August 11, 2024 10:43

@garthvh garthvh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rcarteraz rcarteraz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fiddled around with it and it's working good for me. Nice work!

@Hunter275 Hunter275 merged commit 2b34d78 into meshtastic:master Aug 15, 2024
@Hunter275

Copy link
Copy Markdown
Member Author

Thanks yall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request help wanted Extra attention is needed major change This is a major change parity Feature is in other app (iOS, Android, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Update Channel Password flavor text

4 participants