2.8: Refactor NodeInfoLite structure and add legacy support for migration#910
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow pull-request / build (pull_request).
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the device-only persisted NodeDB schema to reduce per-node RAM/flash footprint by slimming NodeInfoLite, while adding a legacy descriptor to decode older /prefs/nodes.proto saves during migration.
Changes:
- Removed (reserved)
NodeInfoLiteembeddedUserLite,PositionLite, andDeviceMetrics, replacing them with flattened user fields and new per-node “satellite” entry arrays inNodeDatabase. - Added nanopb sizing overrides for the new flattened
NodeInfoLitefields. - Introduced
deviceonly_legacy.proto+.optionsto decode the pre-split NodeDB format during v24 → v25 migration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
meshtastic/deviceonly.proto |
Slims NodeInfoLite and adds satellite per-node arrays to NodeDatabase. |
meshtastic/deviceonly.options |
Adds nanopb sizing/int_size overrides for flattened NodeInfoLite user fields. |
meshtastic/deviceonly_legacy.proto |
Adds legacy NodeDB schema for migration decoding of older saves. |
meshtastic/deviceonly_legacy.options |
Adds nanopb integer sizing for legacy migration messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot buf format |
Agent-Logs-Url: https://github.com/meshtastic/protobufs/sessions/df6c83e6-b057-425c-8533-f83df8ed0c75 Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>
Contributor
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.