Skip to content

SEN5X sensor definition#723

Merged
caveman99 merged 6 commits into
meshtastic:masterfrom
fablabbcn:feat/add-sen5x
Jul 21, 2025
Merged

SEN5X sensor definition#723
caveman99 merged 6 commits into
meshtastic:masterfrom
fablabbcn:feat/add-sen5x

Conversation

@oscgonfer

@oscgonfer oscgonfer commented Jul 6, 2025

Copy link
Copy Markdown
Contributor

Adds a new sensor definition for the SEN5X series.

Shouldn't merge yet, as it adds it naively and I am not sure we should use SEN5X, or SEN50, SEN54 and SEN55 separately.

@oscgonfer oscgonfer marked this pull request as draft July 6, 2025 17:30
@oscgonfer

oscgonfer commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

I added new definitions for the SEN5X sensor here. My OCD tells me that PM4.0 should go in order, but I refrained from doing that...

This keeps uint32_t for PM, but adds float for other values. Let me know if that's OK @caveman99

I am tempted to discuss this a bit further though. Its good to have the float there as the sensor provides the accuracy, but it'd require homogeneity across different sensors.

If we then want to save space in the payload, this and other sensors would require scaling.

@oscgonfer oscgonfer marked this pull request as ready for review July 17, 2025 11:58
@oscgonfer

oscgonfer commented Jul 19, 2025

Copy link
Copy Markdown
Contributor Author

Will conflict with #732 and with #717

@caveman99 caveman99 merged commit ee4d961 into meshtastic:master Jul 21, 2025
1 of 2 checks passed
@oscgonfer oscgonfer deleted the feat/add-sen5x branch July 21, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants