Add CO2 sensor temperature and relative humidity#719
Merged
Conversation
1534377 to
7069b85
Compare
3 tasks
caveman99
approved these changes
Jul 2, 2025
thebentern
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two new protobuf definitions in the Air quality telemetry module, for multisensor CO2 nodes. Many CO2 sensors have an embedded T and RH sensor, that is used for compensation of the readings. This PR adds them as a separate metric, because the temperature of the CO2 sensor is not "real air temperature".
It's interesting to have these sensors separate because the "CO2 sensor temperature" is not accurate and it's a good value for the those that want to study the performance of the CO2 sensor (and that doesn't trust the algorithm running in the firmware).
If we replaced the
environment_metricswith these values, the "concern" would be to have a very low accuracy temperature sensor that could be misunderstood and misleading.