zero fields before using them in udp multicast#56
Merged
Conversation
As a Go programer I expect all datatypes to have a default constructor initializing to a zero value, because in Go all new values always have a all zeros default value. When I implemented ce9335d I forgot to initialize _fd & _quit to zero values. This would have been caught by clang's UB sanitizers, we should make a *SAN build. Needed for meshtastic/firmware#6683
This was referenced Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a Go programer I expect all datatypes to have a default constructor initializing to a zero value, because in Go all new values always have a all zeros default value.
When I implemented ce9335d I forgot to initialize _fd & _quit to zero values.
This would have been caught by clang's UB sanitizers, we should make a *SAN build.
Needed for meshtastic/firmware#6683