Fix for GPS not using pins defined in variant.h if set as "Pin 0" through app. ONLY WORKING ON PROMICRO#8951
Closed
macvenez wants to merge 2 commits into
Closed
Fix for GPS not using pins defined in variant.h if set as "Pin 0" through app. ONLY WORKING ON PROMICRO#8951macvenez wants to merge 2 commits into
macvenez wants to merge 2 commits into
Conversation
Xaositek
requested changes
Dec 13, 2025
Xaositek
left a comment
Contributor
There was a problem hiding this comment.
I have a small concern that the variables were also renamed in the PR; this would make these devices an exception to the codebase. I think we need to keep with convention and have them all unified. If we need to flip them in order for this to work, that's completely acceptable.
Before:
PIN_GPS_TX
PIN_GPS_RX
After:
GPS_RX_PIN
GPS_TX_PIN
Contributor
Collaborator
|
I need to check this properly. The premise is correct - the |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't accept as it will break GPS on all boards but nrf52_promicro_tcxo
As discussed on discord here this should fix the GPS issue.
Tested and working on
nrf52_promicro_tcxowon't work on other boards as pins are swapped nowHad to swap them again in promicro. How do we want to go with the other boards?