NodeDB: clearAllFavorites() when switching role to CLIENT_BASE#8534
Closed
compumike wants to merge 3 commits into
Closed
Conversation
…-switching-to-client-base
fifieldt
approved these changes
Nov 4, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shalberd
reviewed
Nov 4, 2025
…oDisk` only if it made changes Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Marking as draft so this doesn't get merged until there's some sort of consensus one way or another whether to include this feature, per comment at #8514 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One part of the larger feature request [Feature Request]: CLIENT_BASE: make it harder to "accidentally" favorite other nodes #8514 (comment)
Tested and working here, switching roles back and forth.
🤝 Attestations