(For NIMBLE_TWO testing:) #8404 plus NimbleBluetooth.cpp NIMBLE_TWO changes from #7880#8405
Closed
compumike wants to merge 3 commits into
Closed
Conversation
…g with 0-length reads during config phase)
…different constant to represent no connection
…o NimbleBluetooth.cpp compiles with NIMBLE_TWO
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is a PR with extra one commit on top of #8404 that I needed in order to test #8404 with
NIMBLE_TWOonheltec-v3, but I've separated it into a different PR because I don't have a C6L to test with.)Full credit to @Links2004 -- this is @Links2004 's changes to
NimbleBluetooth.cppextracted from their PR https://github.com/meshtastic/firmware/pull/7880/files . I found that applying these changes was necessary for me to build and run successfully withNIMBLE_TWOonheltec-v3: see my comment here #8404 (comment)Unlike #7880, this PR does not change any
arch/*orvariants/*files, so it would only affect platforms that are already usingNIMBLE_TWO. (OnlyM5STACK_UNITC6LI believe?)Can anyone with a C6L test #8404 alone, versus this branch (which includes #8404)?