Skip to content

Add some manual github actions to make building subsets easier#7530

Closed
NomDeTom wants to merge 5 commits into
meshtastic:developfrom
NomDeTom:master
Closed

Add some manual github actions to make building subsets easier#7530
NomDeTom wants to merge 5 commits into
meshtastic:developfrom
NomDeTom:master

Conversation

@NomDeTom

@NomDeTom NomDeTom commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

Added 3 new workflows:

  • Build Target List - makes a list of all of the targets within each arch
  • Build One Arch - builds everything in a particular arch
  • Build One Target - accepts a build target from the action above and builds it.

I've also added another conditional to one of the workflows to stop it running automatically on a fork.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@NomDeTom

NomDeTom commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator Author

@vidplace7

@vidplace7 vidplace7 self-assigned this Aug 1, 2025
@vidplace7 vidplace7 added the github_actions Pull requests that update GitHub Actions code label Aug 1, 2025
@vidplace7 vidplace7 self-requested a review August 1, 2025 15:36

@DaneEvans DaneEvans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, especially the changes to run only here.

I'm a bit concerned at the proliferation of additional pipelines, but manual only shouldn't pose an issue

@NomDeTom NomDeTom closed this Aug 5, 2025
@NomDeTom NomDeTom reopened this Aug 5, 2025
@NomDeTom NomDeTom marked this pull request as draft August 5, 2025 02:03
@NomDeTom NomDeTom closed this Aug 5, 2025
@NomDeTom NomDeTom reopened this Aug 5, 2025
@NomDeTom NomDeTom marked this pull request as ready for review August 5, 2025 02:04
@NomDeTom

NomDeTom commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

Looks good, especially the changes to run only here.

I'm a bit concerned at the proliferation of additional pipelines, but manual only shouldn't pose an issue

This is intended to only really be run on a forked repo, hence all the additional guards.

@fifieldt

Copy link
Copy Markdown
Member

Thanks for this. The guards are good - having random actions run on forks is annoying :)

Q) These are nicely laid out. Is there a way they could be integrated into existing actions to avoid that little bit of duplication? (actually, is there any overlap?)

@NomDeTom

Copy link
Copy Markdown
Collaborator Author

@fifieldt I did consider rolling it all into the existing builder, but the actions to generate the matrix interferes with the generation of a single build target - the final build one target splits the action in two at this point. The build one arch and build target list are semi-superfluous, I suppose, but they're good demos of how their relevant actions work.

@NomDeTom NomDeTom changed the base branch from master to develop August 29, 2025 15:28
@NomDeTom NomDeTom closed this by deleting the head repository Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants