Skip to content

Fix 10799#10819

Merged
thebentern merged 2 commits into
developfrom
fix-10799
Jun 30, 2026
Merged

Fix 10799#10819
thebentern merged 2 commits into
developfrom
fix-10799

Conversation

@caveman99

@caveman99 caveman99 commented Jun 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation

    • Clarified guidance to avoid editing regenerated protobuf files and to route protobuf changes through the source repository and regen workflow.

  • Bug Fixes

    • Improved ESP32-S2 USB support by explicitly enabling TinyUSB settings.
    • Added a board configuration check for the Nugget S2 LoRa environment to catch setup issues earlier.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@github-actions github-actions Bot added needs-review Needs human review bugfix Pull request that fixes bugs labels Jun 30, 2026
@caveman99 caveman99 requested a review from vidplace7 June 30, 2026 10:43
@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 80cd4e7c-bf5a-458b-abc1-3f59dbad9e57

📥 Commits

Reviewing files that changed from the base of the PR and between 87bb149 and bc373ce.

📒 Files selected for processing (4)
  • .github/copilot-instructions.md
  • AGENTS.md
  • variants/esp32s2/esp32s2.ini
  • variants/esp32s2/nugget_s2_lora/platformio.ini
📝 Walkthrough

Walkthrough

Adds rules to AGENTS.md and .github/copilot-instructions.md forbidding AI edits to src/mesh/generated/. Also enables TinyUSB and CDC in the ESP32-S2 base sdkconfig, and adds board_check = true to the nugget-s2-lora variant.

Changes

AI Agent Guardrails

Layer / File(s) Summary
No-edit rules for generated protobufs
AGENTS.md, .github/copilot-instructions.md		 Both files gain a rule forbidding manual edits/commits to src/mesh/generated/, directing .proto changes through the protobufs repo and regen workflow.

ESP32-S2 TinyUSB Build Config

Layer / File(s) Summary
TinyUSB sdkconfig and board_check
variants/esp32s2/esp32s2.ini, variants/esp32s2/nugget_s2_lora/platformio.ini		 esp32s2.ini adds CONFIG_TINYUSB_ENABLED=y and CONFIG_TINYUSB_CDC_ENABLED=y with a comment about the missing USB-Serial-JTAG peripheral; nugget_s2_lora/platformio.ini adds board_check = true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops by the generated files,
"Don't touch those!" it warns with bright eyes.
The ESP32-S2 gets TinyUSB today,
And board_check keeps bad configs away.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required template sections and attestations are missing. Replace the placeholder text with a real description and complete the attestations/testing notes, including any affected hardware and regressions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is tied to the issue being fixed, though it is terse and not very descriptive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@thebentern thebentern merged commit 3edc89d into develop Jun 30, 2026
82 of 84 checks passed
@thebentern thebentern deleted the fix-10799 branch June 30, 2026 11:01
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Firmware Size Report

22 targets | vs develop: 22 increased, net +11,688 (+11.4 KB)

Target Size vs develop
heltec-vision-master-e213-inkhud 2,230,240 📈 +2,880 (+2.8 KB)
t-deck-tft 3,811,728 📈 +1,056 (+1.0 KB)
station-g3 2,266,848 📈 +496
rak11200 1,861,088 📈 +480
station-g2 2,266,832 📈 +480
Show 17 more target(s)
Target Size vs develop
heltec-v3 2,264,544 📈 +464
heltec-v4 2,277,760 📈 +464
rak3312 2,272,704 📈 +464
heltec-ht62-esp32c3-sx1262 2,135,440 📈 +448
seeed-xiao-s3 2,276,592 📈 +448
tlora-c6 2,368,752 📈 +448
t-eth-elite 2,491,920 📈 +432
elecrow-adv-35-tft 3,417,040 📈 +416
pico2w 1,220,932 📈 +416
picow 1,245,240 📈 +360
seeed_xiao_rp2350 768,296 📈 +360
pico2 770,128 📈 +352
pico 783,016 📈 +328
rak11310 805,752 📈 +328
seeed_xiao_rp2040 781,232 📈 +328
wio-e5 238,756 📈 +128
rak3172 186,408 📈 +112

Updated for a2a2de1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vidplace7 vidplace7 Awaiting requested review from vidplace7

Assignees

No one assigned

Labels

bugfix Pull request that fixes bugs needs-review Needs human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caveman99 @thebentern