Skip to content

[Bug]: RAK4631- AirQualityTelemetry - RAK12039 PM sensor #5582

Description

@beegee-tokyo

Category

Other

Hardware

Rak4631

Firmware Version

2.5.15.79da236

Description

RAK12039 PM values transmitted and decoded have all PM values set to 0 when sent to MQTT broker.

Reason:
Most likely a change in the protobuf (not sure) where additional "has_pmxxx_standard" and "has_pmxxx_environmental" validator fields were added to the air_quality_metrics structure.
But AirQualityTelemetry.cpp does not set these validation fields to true.

This results in sending all PM values as 0 to the MQTT broker.

Fix:
In AirQualityTelemetry.cpp ==> bool AirQualityTelemetryModule::getAirQualityTelemetry(meshtastic_Telemetry *m) the validation markers need to be set to true.

    m->variant.air_quality_metrics.pm10_standard = data.pm10_standard;
    m->variant.air_quality_metrics.pm25_standard = data.pm25_standard;
    m->variant.air_quality_metrics.pm100_standard = data.pm100_standard;

    m->variant.air_quality_metrics.pm10_environmental = data.pm10_env;
    m->variant.air_quality_metrics.pm25_environmental = data.pm25_env;
    m->variant.air_quality_metrics.pm100_environmental = data.pm100_env;

changed to

    m->variant.air_quality_metrics.has_pm10_standard = true;
    m->variant.air_quality_metrics.pm10_standard = data.pm10_standard;
    m->variant.air_quality_metrics.has_pm25_standard = true;
    m->variant.air_quality_metrics.pm25_standard = data.pm25_standard;
    m->variant.air_quality_metrics.has_pm100_standard = true;
    m->variant.air_quality_metrics.pm100_standard = data.pm100_standard;

    m->variant.air_quality_metrics.has_pm10_environmental = true;
    m->variant.air_quality_metrics.pm10_environmental = data.pm10_env;
    m->variant.air_quality_metrics.has_pm25_environmental = true;	
    m->variant.air_quality_metrics.pm25_environmental = data.pm25_env;
    m->variant.air_quality_metrics.has_pm100_environmental = true;	
    m->variant.air_quality_metrics.pm100_environmental = data.pm100_env;

fixes the problem and PM air quality values are sent over MQTT.

Relevant log output

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions