feat: add heltec_v4_r8 board#308
Merged
Merged
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a new Heltec board variant (HELTEC_V4_R8_TFT) by introducing a dedicated LovyanGFX driver and wiring it into display creation and SD-card SPI initialization.
Changes:
- Add
LGFX_HELTEC_V4_R8_TFTdisplay driver implementation. - Register the new driver in
DisplayDriverFactorybehindHELTEC_V4_R8_TFT. - Adjust SD-card SPI init path for
HELTEC_V4_R8_TFTto explicitlySPI.begin(...)on ESP32S3.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/graphics/driver/DisplayDriverFactory.cpp | Adds include + factory switch case for the new HELTEC v4 R8 TFT driver |
| source/graphics/common/SdCard.cpp | Adds board-specific SPI init override for SD card on HELTEC v4 R8 |
| include/graphics/LGFX/LGFX_HELTEC_V4_R8_TFT.h | New LovyanGFX driver/header for HELTEC v4 R8 TFT (panel/bus/backlight + optional touch wrapper) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RAM has been increased compared to the original v4 to facilitate the use of more functions such as maps. However, the pinout is significantly different from the original v4 and incompatible, so a new model has been submitted.