Skip to content

Reorder bottom navigation tabs to canonical order#1851

Merged
garthvh merged 2 commits into
mainfrom
copilot/align-navigation-tabs
May 20, 2026
Merged

Reorder bottom navigation tabs to canonical order#1851
garthvh merged 2 commits into
mainfrom
copilot/align-navigation-tabs

Conversation

Copilot AI commented May 20, 2026

Copy link
Copy Markdown
Contributor

What changed?

Reordered bottom tab bar from Messages, Connect, Nodes, Mesh Map, Settings to the canonical cross-platform order: Messages, Nodes, Map, Settings, Connect. Renamed "Mesh Map" tab label to "Map".

  • ContentView.swift — Reordered tabs in both iOS 18+ (Tab API) and legacy (tabItem API) code paths
  • NavigationState.swift — Reordered Tab enum cases to match
  • docs/developer/deep-links.md + generated HTML — Renamed section heading

Why did it change?

Aligns with the Menu Alignment Audit canonical tab order. Messages first (primary use-case), Connect last (infrequent after initial pairing), "Map" label standardised across platforms.

How is this tested?

Tab routing is value-based (enum matching), not position-dependent — reordering has no effect on deep links or state restoration. Existing RouterDeepLinkTests and NavigationStateTests continue to pass without modification.

Screenshots/Videos (when applicable)

N/A — no CI simulator available; tab order change is declarative SwiftUI reordering.

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have verified whether these changes require updates to the in-app documentation under docs/user/ or docs/developer/, and updated accordingly (see copilot-instructions.md for the view → doc page mapping). If no doc update is needed, add the skip-docs-check label.
  • I have tested the change to ensure that it works as intended.

Copilot AI linked an issue May 20, 2026 that may be closed by this pull request
3 tasks
… to Map

Tab order changed from: Messages, Connect, Nodes, Mesh Map, Settings
to canonical order: Messages, Nodes, Map, Settings, Connect

- Reordered both iOS 18+ (Tab API) and legacy (tabItem API) paths
- Renamed "Mesh Map" tab label to "Map" for cross-platform consistency
- Updated NavigationState.Tab enum case ordering
- Updated deep-links documentation headings

Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/5f19d3ad-9e6e-4e3e-82eb-5a83def003f6

Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
Copilot AI changed the title [WIP] Reorder bottom navigation tabs to canonical order Reorder bottom navigation tabs to canonical order May 20, 2026
Copilot AI requested a review from garthvh May 20, 2026 20:18
@garthvh garthvh marked this pull request as ready for review May 20, 2026 20:33
@garthvh garthvh merged commit 5ccbfec into main May 20, 2026
4 checks passed
@garthvh garthvh deleted the copilot/align-navigation-tabs branch May 20, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ALIGNMENT] Reorder bottom navigation tabs to canonical order

2 participants