Skip to content

Align node list long-press context menu to canonical order#1850

Merged
garthvh merged 2 commits into
mainfrom
copilot/align-node-list-context-menu
May 21, 2026
Merged

Align node list long-press context menu to canonical order#1850
garthvh merged 2 commits into
mainfrom
copilot/align-node-list-context-menu

Conversation

Copilot AI commented May 20, 2026

Copy link
Copy Markdown
Contributor

What changed?

Restructured the node list long-press context menu to match the cross-platform canonical order from the Menu Alignment Audit:

  1. Add to favorites / Remove from favorites
  2. Mute notifications / Unmute (was "Hide alerts / Show alerts")
  3. Message
  4. Trace Route
  5. Ignore / Remove from ignored (was "Ignore Node / Remove from ignored")
  6. Remove (was "Delete Node")

Removed from context menu (remain accessible in Node Detail):

  • Share Contact QR
  • Exchange Positions
  • Exchange User Info
  • Client History

Why did it change?

Aligns iOS with Android and firmware API terminology. Reduces cognitive load (6 items vs 10). Places most-used actions first, destructive action last.

How is this tested?

Manual verification of context menu item order, labels, and destructive action placement. Confirmed removed items are still present in NodeDetail's actionsSection.

Screenshots/Videos (when applicable)

N/A — label and ordering changes only; no layout or visual design changes.

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have verified whether these changes require updates to the in-app documentation under docs/user/ or docs/developer/, and updated accordingly (see copilot-instructions.md for the view → doc page mapping). If no doc update is needed, add the skip-docs-check label.
  • I have tested the change to ensure that it works as intended.

- Reorder to: Favorite, Mute notifications, Message, Trace Route, Ignore, Remove
- Rename "Hide alerts"/"Show alerts" to "Mute notifications"/"Unmute"
- Rename "Ignore Node" to "Ignore"
- Rename "Delete Node" to "Remove"
- Remove Share Contact QR, Exchange Positions, Exchange User Info, Client History from context menu (still accessible from Node Detail)
- Update docs to reflect new menu structure

Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/73cd1084-c740-4f6b-91e9-77bc68920c25

Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
Copilot AI changed the title [WIP] Align node list long-press context menu to canonical order Align node list long-press context menu to canonical order May 20, 2026
Copilot AI requested a review from garthvh May 20, 2026 20:17
@garthvh garthvh marked this pull request as ready for review May 21, 2026 05:21
@garthvh garthvh merged commit 64e8b04 into main May 21, 2026
3 of 4 checks passed
@garthvh garthvh deleted the copilot/align-node-list-context-menu branch May 21, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ALIGNMENT] Align node list long-press context menu to canonical order

2 participants