Add TAK Config settings screen#1658
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated TAK Module configuration screen to the iOS app, allowing configuration of TAK identity fields (team + role) for nodes running the TAK / TAK Tracker device roles, and wires the config into the existing admin/config request + persistence pipeline.
Changes:
- Introduce a new SwiftUI TAK Module Config form (team + role) and route it into Settings navigation.
- Add radio/admin request + save plumbing for TAK module config, including packet handling and Core Data upsert support.
- Add a new Core Data model version including
TAKConfigEntity, and update localization strings for the new UI text.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Meshtastic/Views/Settings/TAKServerConfig.swift | Adds TAKModuleConfig UI for TAK module identity settings (team/role). |
| Meshtastic/Views/Settings/Settings.swift | Adds navigation entry + destination for the new TAK module config screen. |
| Meshtastic/Router/NavigationState.swift | Adds SettingsNavigationState.takConfig route. |
| Meshtastic/Persistence/UpdateCoreData.swift | Adds Core Data upsert helpers for received TAK module config packets. |
| Meshtastic/Helpers/MeshPackets.swift | Handles incoming TAK module config variant and routes it to persistence. |
| Meshtastic/Accessory/Accessory Manager/AccessoryManager+ToRadio.swift | Adds admin request/save methods for TAK module config. |
| Meshtastic/Meshtastic.xcdatamodeld/MeshtasticDataModelV 57.xcdatamodel/contents | New model version including TAKConfigEntity and relationship from NodeInfoEntity. |
| Meshtastic/Meshtastic.xcdatamodeld/.xccurrentversion | Bumps current Core Data model version to v57. |
| Meshtastic.xcodeproj/project.pbxproj | Registers the new Core Data model version in the project. |
| Localizable.xcstrings | Adds/updates string-catalog entries for the new TAK module config UI text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added TAK Config settings screen for TAK / TAK Tracker roles
Screenshots/Videos (when applicable)
Checklist