Transports Interface to Support TCP for all Platforms and Serial on Mac#1341
Merged
Conversation
… into transports
…into transports # Conflicts: # Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift
…-Apple into transports # Conflicts: # Meshtastic.xcodeproj/project.pbxproj
# Conflicts: # Localizable.xcstrings # Meshtastic/MeshtasticApp.swift # Meshtastic/Views/Helpers/ConnectedDevice.swift
# Conflicts: # Meshtastic.xcodeproj/project.pbxproj # Meshtastic/Views/Nodes/NodeList.swift
…y with the accent color
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a transport interface abstraction to support TCP connections on iOS and Serial connections on Mac in addition to the existing Bluetooth Low Energy (BLE) support, and upgrades the codebase to Swift 6.
Key changes include:
- Replaced
BLEManagerwith a newAccessoryManagerthat abstracts transport connections - Updated URL schemes and tab names from "bluetooth" to "connect"
- Added transport logging category and enhanced debug capabilities
Reviewed Changes
Copilot reviewed 131 out of 138 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/lint/lint-fix-changes.sh | Added SwiftLint configuration file reference for precommit hooks |
| Widgets/WidgetsLiveActivity.swift | Updated URL scheme from "bluetooth" to "connect" |
| MeshtasticTests/RouterTests.swift | Updated test cases to use "connect" tab instead of "bluetooth" |
| Settings/UserConfig.swift | Refactored to use AccessoryManager instead of BLEManager |
| Onboarding/DeviceOnboarding.swift | Added local network and Bluetooth permission flows |
| Views/Helpers/* | Updated ConnectedDevice component to remove Bluetooth-specific references |
| Multiple config files | Converted synchronous BLE operations to async/await patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thebentern
approved these changes
Aug 27, 2025
|
Awesome to see this. Much appreciated and many thanks! |
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.