fix(ui): stop node signal pill from wrapping; restore full-width spread#6007
Merged
Conversation
The SNR/RSSI/quality signal pill wrapped onto multiple lines on real phone widths — "dBm" dangled onto its own line and the chip looked crushed. Cause: #5985 bundled SNR + RSSI + quality into one StatusSurface pill (for legibility scrim) but left it as a single MetricsGrid item, so it was forced into a 1/3-width column and its text had nowhere to go. Before #5985 these were three separate grid items spread edge-to-edge. Fix: render the signal pill on its own full-width line (SpaceBetween: SNR left, RSSI center, quality right) — the pre-scrim spread, now with the scrim. Short metrics (channel, sats) still flow through the grid. Adds a screenshot sample (hopsAway = 0) that actually exercises the signal pill — every existing sample had hopsAway >= 1 and rendered the hops chip instead, which is why the regression slipped through CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On real phone widths the node-card signal pill (SNR / RSSI / quality) wrapped onto multiple lines —
dBmdangled onto its own line and the chip looked crushed:🐛 Fix
#5985 bundled SNR + RSSI + quality into a single
StatusSurfacepill (to give the bright status colors a legibility scrim) but left it as oneMetricsGriditem — so it was forced into a 1/3-width column with nowhere for the text to go. Before #5985 these were three independent grid items spread edge-to-edge.This renders the signal pill on its own full-width line (
Arrangement.SpaceBetween: SNR left, RSSI center, quality right) — the pre-scrim spread, now with the scrim behind it. Short metrics (channel, sats) still flow through the grid below.SNR 14.00 dB -41/dBmcrammed in a 1/3 columnSNR … RSSI … ◢ Goodspread full-width on its own lineCompact density is unaffected — it lives in
NodeItemCompactand shows a single quality chip, not the SNR/RSSI pill.🧹 Test coverage
The regression slipped through CI because every existing node screenshot sample had
hopsAway >= 1, so they rendered the hops chip instead of the signal pill. AddsScreenshotSampleNodeCompleteDirectSignal(ahopsAway = 0direct neighbor) that actually exercises the pill, with regenerated light/dark references.Testing Performed
spotlessApply spotlessCheck,detekt,assembleDebug— pass:core:ui:allTests(60) and:feature:settings:allTests(92) — pass:screenshot-tests:updateDebugScreenshotTest— pass; new references reviewed visually🤖 Generated with Claude Code