refactor(car): drop dead FuzzyNodeNameResolver duplicate#5994
Merged
Conversation
The car-local FuzzyNodeNameResolver was referenced only by its own unit test — no production code ever used it. core:data already provides the canonical @single FuzzyNameResolver (and feature:car already depends on core:data), so the AppFunctions-merge TODO to consolidate is resolved by simply removing the duplicate class and its test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
feature/car'sFuzzyNodeNameResolvercarried a TODO to consolidate withcore/data'sFuzzyNameResolveronce the AppFunctions branch merged. That branch has merged, unblocking the cleanup.On inspection, the car-local resolver turned out to be dead code — referenced only by its own unit test, never by any production code in
feature:car.core:dataalready provides the canonical@Single FuzzyNameResolver(andfeature:caralready depends oncore:data), so the dedup is a straight deletion rather than a rewire.🧹 Cleanup
feature/car/.../util/FuzzyNodeNameResolver.kt(the duplicate class + its TODO).feature/car/.../util/FuzzyNodeNameResolverTest.kt(the only consumer).No call sites to update — there were none. The core resolver remains DI-registered and available should
feature:carever grow a voice-resolve feature. (Note the APIs differ: core takes a query + injected node DB →NodeNameResult; the removed car one took an explicitList<Pair<Int, String>>→ confidence score.)Testing Performed
./gradlew :feature:car:assembleDebug :feature:car:testFdroidDebugUnitTest detekt spotlessCheck— all green.🤖 Generated with Claude Code