refactor(settings): replace SimpleDateFormat with kotlinx-datetime#5992
Merged
Conversation
Swap the two java.text.SimpleDateFormat export-filename timestamps in :feature:settings for the kotlinx-datetime LocalDateTime.Format idiom already used in Debug.kt, dropping the java.text/java.util.Locale and toDate/toInstant helper imports. Behaviour preserved: device-local time, same yyyyMMdd / yyyyMMdd_HHmmss patterns. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧹 Why
:feature:settingshad the last twojava.text.SimpleDateFormatusages in the app — Android-only JDK date formatting in a module that's otherwise KMP-friendly. This tidies them up to thekotlinx-datetimeLocalDateTime.Formatidiom already established inDebug.kt.🛠️ What changed
SettingsScreen.kt— node-config export filename timestamp (yyyyMMdd).PersistenceSection.kt— range-test / data-log export filename timestamp (yyyyMMdd_HHmmss); the format descriptor is hoisted to a top-levelval(keeps the composable under detekt'sLongMethodlimit).java.text.SimpleDateFormat,java.util.Locale, andtoDate/toInstantimports.Notes for reviewers
TimeZone.currentSystemDefault()) and the same date patterns, so exported filenames are unchanged.Debug.ktusesTimeZone.UTC; I deliberately did not match that here to avoid changing existing filename semantics — happy to switch if UTC is preferred.Testing Performed
./gradlew spotlessCheck detekt :feature:settings:compileAndroidMain— all pass.🤖 Generated with Claude Code