fix(data): Persist TAK module config#5933
Merged
jamesarich merged 1 commit intoJun 24, 2026
Merged
Conversation
Add the tak oneOf branch to ModuleConfigDataSource.setLocalModuleConfig so received TAK configs persist to LocalModuleConfig instead of being silently dropped. Add the matching tak label to the ModuleConfig.summarize helper in MeshConfigHandlerImpl so handleModuleConfig's debug log reports "tak" instead of "unknown". Both branches mirror existing per-variant entries in each when block.
jamesarich
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes TAK module configuration persistence.
Received TAK module configs were handled by the generated protobuf model, but
ModuleConfigDataSource.setLocalModuleConfig(...)did not copy the TAK branch intoLocalModuleConfig. As a result, TAK config updates could be received but not persisted locally. The module-config debug summary also did not recognize TAK configs and reported them asunknown.Key Changes
config.takintoLocalModuleConfig.takinMeshConfigHandlerImplsummaries.Testing
Migration Notes