test(firmware): re-record disclaimer screenshot baselines (follow-up to #5925)#5926
Merged
Merged
Conversation
Follow-up to #5925, which merged the painterResource fix without the regenerated baselines, leaving validateDebugScreenshotTest red on main. The ScreenshotFirmwareDisclaimer Light/Dark baselines were captured while ChirpyCard fed the bundled drawable to Coil, which rendered nothing. Now that #5925 renders chirpy via painterResource the pixels differ, so the baselines (and the firmware_disclaimer.png docs copy) are re-recorded. :screenshot-tests:validateDebugScreenshotTest passes (246 tests, 0 failures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #5925. That PR fixed the firmware "ladder" disclaimer dialog to render the chirpy mascot via
painterResource(previously it was fed to Coil'sAsyncImage, which has no decoder for a bundled ComposeDrawableResourceand rendered nothing). It was merged with only the source-fix commit — the regenerated screenshot baselines were left behind, sovalidateDebugScreenshotTestis now red on main: the committedScreenshotFirmwareDisclaimerbaselines still show the blank chirpy.Changes
🧹 Chores
ScreenshotFirmwareDisclaimerLight/Dark CST reference baselines and thefirmware_disclaimer.pngdocs copy so they match the now-rendering chirpy.Testing Performed
:screenshot-tests:validateDebugScreenshotTestpasses (246 tests, 0 failures). Confirmed the regenerated baseline visually shows chirpy beside the ladder.No source changes — baseline images only.