fix(settings): gate Traffic Management config at firmware v2.8.0#5864
Merged
Conversation
The Traffic Management config screen was gated at firmware v3.0.0, hiding a feature whose firmware support already ships on the 2.8 line. The firmware TrafficManagementModule (src/modules/TrafficManagementModule.cpp) landed on 2.8 via meshtastic/firmware#10413, AdminModule handles TRAFFICMANAGEMENT_CONFIG, and Modules.cpp instantiates it; firmware version.properties is 2.8.0. There is no v3.0.0 firmware, so the v3.0.0 gate (a placeholder from #4671's "upcoming support") hid a working feature. Lower the gate to V2_8_0, matching the constant StatusMessage already uses, and drop the now-unused V3_0_0 constant. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Why
The Traffic Management radio-config screen was gated at firmware v3.0.0, hiding a feature whose firmware support already ships on the 2.8 line. There is no v3.0.0 firmware, so the screen was effectively unreachable for every real device.
The v3.0.0 value was a placeholder introduced in #4671 ("upcoming support") and never reconciled once the firmware actually landed.
Firmware support is present on 2.8.0 (verified 2026-06-18):
src/modules/TrafficManagementModule.cppshipped on the 2.8 line (added 2026-05-09 via 2.8: NodeDB shrink, decoupling, and restructuring firmware#10413, "2.8: …").AdminModulehandlesTRAFFICMANAGEMENT_CONFIGandModules.cppinstantiates the module.version.propertiesismajor=2 minor=8 build=0.🛠️ What
supportsTrafficManagementConfigfromatLeast(V3_0_0)toatLeast(V2_8_0)— the same constantsupportsStatusMessagealready uses.V3_0_0constant.🐛 Testing Performed
CapabilitiesTestto expectfalsebelow 2.8.0 andtrueat/above 2.8.0 (mirroring the StatusMessage test)../gradlew :core:model:allTests— pass../gradlew spotlessApply detekt— clean.🤖 Generated with Claude Code