feat(node): show our node shortname chip on the Nodes tab#5820
Merged
Conversation
The Nodes tab was the only top-level tab that suppressed the connected node's shortname chip in the app bar. Show it with the same condition the other tabs use (Conversations, Connected, Mesh map), so the chip lives in the same upper-right position for muscle memory when managing multiple nodes. Tapping it opens our node's detail, matching the other tabs. Fixes #5004 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
8ef67ba to
265dfbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every top-level tab — Conversations, Mesh map, Settings, Connected — shows the connected node's shortname chip in the app bar's upper-right corner, except the Nodes tab, which suppressed it. This adds the chip there in the same place and the same way, so it's consistent and predictable when managing multiple nodes.
Fixes #5004
🌟 New Features
MainAppBaron the Nodes list now shows our node's shortname chip, gated on the same condition the other tabs use (ourNode != null && connectionState is ConnectionState.Connected), instead of being hard-coded off.navigateToNodeDetailscallback — matching the chip's behavior on the other tabs.Notes
ourNode,connectionState, andnavigateToNodeDetailswere already in scope inNodeListScreen.