fix(proto): prune TakTalkMessage and TakTalkRoomData from Wire codegen#5624
Merged
Conversation
The proto submodule update to 9ab4a1d added TakTalkMessage and TakTalkRoomData message types to atak.proto. These are owned by TAKPacket-SDK, so they must be pruned to avoid duplicate class generation that breaks the fdroid release build (rb-check). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto submodule update to
9ab4a1d("Add TAKTALK message and room data structures to atak.proto") introducedTakTalkMessageandTakTalkRoomDatamessage types. These are owned by TAKPacket-SDK, which ships the Wire-generated classes in its KMP artifacts. Without pruning them from our Wire codegen, the fdroid release build produces duplicate classes that break the rb-check CI job.This adds the two missing
prune()directives incore/proto/build.gradle.kts, consistent with how all other TAKPacket-SDK-owned atak.proto types are already handled.