fix(emoji): enable androidResources for core:ui to package emoji-data.json#5597
Merged
Conversation
….json The EmojiPickerDialog crashes with MissingResourceException on build 2320900 because emoji-data.json is not packaged into the APK assets. Root cause: The convention plugin sets androidResources.enable = false for all KMP library modules by default. Without it, CMP files/ resources accessed via Res.readBytes() are not included in the Android AAR asset pipeline — they simply don't make it into the final APK. Fix: Enable androidResources for core:ui (matching core:resources which already has this set). Also add defensive error handling so a resource loading failure shows an error state instead of crashing the app. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📄 Docs staleness check — advisoryThis PR modifies user-facing UI source files but does not update any page under
Changed source files: What to check:
New page checklist (if adding a new doc page):
If this PR does not require a doc update (e.g., internal refactor, bug fix, test change), add the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build 2320900 crashes with
MissingResourceExceptionwhen opening the emoji picker becauseemoji-data.jsonis not packaged into the APK's assets.Root Cause
The convention plugin (
KotlinAndroid.kt) defaults all KMP library modules toandroidResources.enable = false. Without Android resources enabled, Compose Multiplatformfiles/resources -- which rely on AGP's asset pipeline -- are silently excluded from the AAR and never make it into the final APK.The
core:resourcesmodule works because it explicitly overrides this totrue. Thecore:uimodule (which hosts the emoji picker and itsemoji-data.json) did not, soRes.readBytes("files/emoji-data.json")throws at runtime.Changes
core/ui/build.gradle.kts-- EnableandroidResourcesso CMP file resources flow through the asset pipeline into the APK.EmojiPickerViewModel-- Wrappreload()in a try/catch forMissingResourceExceptionandIllegalStateExceptionso future resource failures degrade gracefully (error state in UI) instead of crashing the app.EmojiPickerDialog-- Render an error placeholder whenloadErroris true.Testing
./gradlew :core:ui:compileKotlinJvm-- passes./gradlew :core:ui:allTests-- passes./gradlew :core:ui:detekt-- passes./gradlew :core:ui:spotlessCheck-- passes