Skip to content

fix: consistent column width for compact node list items#5596

Merged
jamesarich merged 2 commits into
mainfrom
jamesarich/super-giggle
May 25, 2026
Merged

fix: consistent column width for compact node list items#5596
jamesarich merged 2 commits into
mainfrom
jamesarich/super-giggle

Conversation

@jamesarich

@jamesarich jamesarich commented May 25, 2026

Copy link
Copy Markdown
Collaborator

The battery info column in the compact node list causes visual misalignment between cards -- nodes with full battery text (e.g. "93%4.11 V") push Column 2 further right than nodes with no battery or just "PWR". This makes the list look jagged.

Adds widthIn(min = 90.dp) to the chip+battery column in NodeItemCompact and switches to Alignment.Start so all cards share a consistent first-column width and left-aligned content.

Before After
Column 1 width varies per card based on battery text length All cards use a minimum 90dp first column with left-aligned content

@jamesarich
fix: set minimum width on compact node chip+battery column
d6d6542 
Add widthIn(min = 90.dp) to the first column in NodeItemCompact
so that cards render with consistent column width regardless of
whether battery info (percentage + voltage) is present.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the bugfix PR tag label May 25, 2026
@jamesarich jamesarich marked this pull request as ready for review May 25, 2026 20:18
@github-actions

github-actions Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📄 Docs staleness check — advisory

This PR modifies user-facing UI source files but does not update any page under docs/en/user/ or docs/en/developer/.

⚠️ Doc changes propagate to 3 consumers: in-app docs browser, Jekyll site (GitHub Pages), and meshtastic.org (Docusaurus sync). Updating a page in docs/en/ automatically flows to all three.

Changed source files:

core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/NodeItemCompact.kt

What to check:

Changed area Likely doc page
feature/messaging/ docs/en/user/messages-and-channels.md
feature/node/ docs/en/user/nodes.md or docs/en/user/node-metrics.md
feature/map/ docs/en/user/map-and-waypoints.md
feature/connections/ docs/en/user/connections.md
feature/settings/ docs/en/user/settings-radio-user.md or docs/en/user/settings-module-admin.md
feature/firmware/ docs/en/user/firmware.md
feature/intro/ docs/en/user/onboarding.md
feature/discovery/ docs/en/user/discovery.md
feature/docs/ Internal docs infrastructure
core/ui/ docs/en/developer/codebase.md or component-specific user pages

New page checklist (if adding a new doc page):

  1. Create the .md file in docs/en/user/ or docs/en/developer/ with last_updated frontmatter
  2. Register in DocBundleLoader.kt with string resources (in-app browser)
  3. Jekyll and Docusaurus sync pick up new pages automatically — no config change needed

If this PR does not require a doc update (e.g., internal refactor, bug fix, test change), add the skip-docs-check label to dismiss this check.

Cross-platform note: This check is advisory while doc coverage matures. Both Android and Apple repos use the same skip-docs-check label and advisory severity. See meshtastic/design standards for shared conventions.

@jamesarich
chore: update screenshot references for compact node layout
d72404b 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesarich jamesarich added this pull request to the merge queue May 25, 2026
Merged via the queue into main with commit 55e7f8f May 25, 2026
18 checks passed
@jamesarich jamesarich deleted the jamesarich/super-giggle branch May 25, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix PR tag

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jamesarich