fix(desktop): keep Vico package to prevent bytecode verification errors#5424
Merged
Conversation
Vico does not ship consumer ProGuard rules. Without explicit keeps, ProGuard's shrinker may remove "redundant" direct super-interfaces from class implementation lists. This causes Kotlin-generated `invokespecial` calls to interface default methods to target an indirect super-interface, which the JVM bytecode verifier rejects as a "Bad invokespecial instruction." - Add `-keep` rules for all classes and interfaces in `com.patrykandpatrick.vico.**` to prevent hierarchy restructuring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vico does not ship consumer ProGuard rules. Without explicit keeps, ProGuard's shrinker may remove "redundant" direct super-interfaces from class implementation lists. This causes Kotlin-generated
invokespecialcalls to interface default methods to target an indirect super-interface, which the JVM bytecode verifier rejects as a "Bad invokespecial instruction."-keeprules for all classes and interfaces incom.patrykandpatrick.vico.**to prevent hierarchy restructuring.