feat: align theme with Design Standards v1.3, remove contrast setting#5355
Merged
Conversation
d572c6c to
49dad50
Compare
49dad50 to
67e6dc6
Compare
Color palette: - Update tertiary from #3949AB to #2855A8 (Blue 700 per spec SVG) - Use Neutral Variant scale for surfaceVariant, onSurfaceVariant, outline, and outlineVariant roles (both light and dark) - Fix onPrimaryContainer light to Green 950 (#002E13) - Fix onTertiaryContainer light/dark to Blue 950 (#1849) - Remove all dead medium/high contrast color variables Theme infrastructure: - Remove ContrastLevel enum, ContrastPickerDialog, SetContrastLevelUseCase - Remove contrastLevel from UiPrefs interface and implementations - Remove contrastLevel from UIViewModel and SettingsViewModel - Simplify AppTheme to just dynamic color OR light/dark scheme Message readability: - Use onSurface for message text (fixes unreadable text on alpha-blended node-color bubbles in dark mode) - Bump message body from bodyMedium (14sp) to bodyLarge (16sp) Custom colors: - Add NeutralVariantPalette, BluePalette, ErrorPalette objects - Extend GreenPalette to full tonal range (950-50) - Update SemanticColors.Accent to #2855A8 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
67e6dc6 to
115ef3e
Compare
|
This changes dont look very good on dark themes on OLED screens. Would be possible to at least add a true black background for OLED/AMOLED screens now that the contrast is gone? That would make OLED phones to use less battery and be better for the eyes. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the Android/Desktop theme with Design Standards v1.3 and removes the contrast level feature entirely.
Changes
Color palette (v1.3 alignment):
#3949AB→#2855A8(Blue 700)surfaceVariant,onSurfaceVariant,outline,outlineVariantnow use the Neutral Variant scaleonPrimaryContainerlight → Green 950 (#002E13)onTertiaryContainer→ Blue 950 (#001849)Contrast removal:
ContrastLevel.kt,ContrastPickerDialog.kt,SetContrastLevelUseCase.ktMessage readability fix:
onSurfaceinstead of node foreground color (fixes unreadable text on alpha-blended bubbles in dark mode)bodyMedium(14sp) →bodyLarge(16sp)CustomColors expanded:
NeutralVariantPalette,BluePalette,ErrorPaletteobjectsGreenPaletteto full range (950–50)Testing
compileDebugKotlin✅:desktop:compileKotlin✅spotlessApply✅detekt✅