feat(settings): Allow clearing the node status message#4577
Merged
Conversation
This commit introduces the ability to clear the node status message. An empty status message from the device is now correctly handled, clearing the status on the app side. Previously, an empty status was ignored. Additionally, a clear button (`X`) has been added to the status message input field in the settings screen, providing a user-friendly way to remove the current status message. Specific changes include: - Modified `MeshNodeManager.updateNodeStatus` to accept a nullable `String` and clear the status if it's null or empty. - Updated `MeshConfigHandler` and `MeshActionHandler` to pass the entire `statusmessage` object, allowing for empty status updates. - Added a trailing clear icon to the `EditTextPreference` for the node status message in `StatusMessageConfigItemList`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4577 +/- ##
==========================================
- Coverage 14.79% 14.79% -0.01%
==========================================
Files 428 429 +1
Lines 14845 14846 +1
Branches 2456 2457 +1
==========================================
Hits 2197 2197
- Misses 12330 12331 +1
Partials 318 318 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to clear the node status message.
An empty status message from the device is now correctly handled, clearing the status on the app side. Previously, an empty status was ignored.
Additionally, a clear button (
X) has been added to the status message input field in the settings screen, providing a user-friendly way to remove the current status message.Specific changes include:
MeshNodeManager.updateNodeStatusto accept a nullableStringand clear the status if it's null or empty.MeshConfigHandlerandMeshActionHandlerto pass the entirestatusmessageobject, allowing for empty status updates.EditTextPreferencefor the node status message inStatusMessageConfigItemList.