refactor(ui): Simplify composable message handling in dialog#4573
Merged
Conversation
This commit refactors the `MeshtasticDialog` invocation within `Main.kt`. It simplifies the logic for handling composable messages by using a `let` scope function, making the code more concise and idiomatic. The explicit `if/else` block for setting the `text` parameter has been replaced with a single line that conditionally provides the composable content. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4573 +/- ##
=======================================
Coverage 14.79% 14.79%
=======================================
Files 427 427
Lines 14841 14841
Branches 2455 2455
=======================================
Hits 2195 2195
Misses 12329 12329
Partials 317 317 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows Client Notification (and other) text only messages to be rendered correctly
fixes #4571