feat(settings): Only show homoglyph setting for Cyrillic locales#4559
Merged
Conversation
The homoglyph character encoding setting is now only displayed to users whose device language is set to one that uses the Cyrillic alphabet (e.g., Russian, Ukrainian, etc.). This change refactors the switch into a new `HomoglyphSetting` composable. Unit tests have been added using Robolectric to verify its visibility logic based on the current locale. The build configuration was updated to enable Android resources in unit tests. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4559 +/- ##
==========================================
- Coverage 14.57% 14.38% -0.20%
==========================================
Files 427 427
Lines 14616 14818 +202
Branches 2428 2452 +24
==========================================
Hits 2131 2131
- Misses 12181 12384 +203
+ Partials 304 303 -1 ☔ View full report in Codecov by Sentry. |
…n BleOtaTransportErrorTest - Wrap transport.close() in try-finally to prevent coroutine leaks on assertion failures - Improve assertion messages to print actual exception on failure - Reduce simulation delay to speed up test execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homoglyph character encoding setting is now only displayed to users whose device language is set to one that uses the Cyrillic alphabet (e.g., Russian, Ukrainian, etc.).
This change refactors the switch into a new
HomoglyphSettingcomposable. Unit tests have been added using Robolectric to verify its visibility logic based on the current locale. The build configuration was updated to enable Android resources in unit tests.This is a followup to #4491 to only display the setting if a supported locale is being used.