feat(messaging): Add bell character to alert message and refine trim#4532
Merged
Conversation
This commit introduces two changes to the messaging feature:
1. The `trim()` function on the message input is replaced with `trim { it.isWhitespace() }` for more precise whitespace removal.
2. A bell character (`\u0007`) is appended to the quick chat alert action message to trigger an audible notification on certain devices.
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4532 +/- ##
=======================================
Coverage 14.42% 14.42%
=======================================
Files 424 424
Lines 14522 14522
Branches 2410 2410
=======================================
Hits 2095 2095
Misses 12124 12124
Partials 303 303 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces two changes to the messaging feature:
trim()function on the message input is replaced withtrim { it.isWhitespace() }for more precise whitespace removal.\u0007) is appended to the quick chat alert action message to trigger an audible notification on certain devices.resikves #4456