feat(messaging): Move message input to Scaffold bottomBar#4530
Merged
Conversation
This commit refactors the `Message` screen to place the message input components (`MessageInput`, `ReplySnippet`, and `QuickChatRow`) within the `bottomBar` of the `Scaffold`. This change ensures that the input fields correctly adjust to the keyboard, preventing it from overlapping the message list. Consequently, the `imePadding()` modifier is no longer needed on the `NavHost` in `Main.kt` and has been removed. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4530 +/- ##
=======================================
Coverage 14.44% 14.44%
=======================================
Files 424 424
Lines 14522 14522
Branches 2410 2410
=======================================
Hits 2097 2097
Misses 12121 12121
Partials 304 304 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
Messagescreen to place the message input components (MessageInput,ReplySnippet, andQuickChatRow) within thebottomBarof theScaffold.This change ensures that the input fields correctly adjust to the keyboard, preventing it from overlapping the message list. Consequently, the
imePadding()modifier is no longer needed on theNavHostinMain.ktand has been removed.resolves #4508